Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n(ko-KR): create card-grid.mdx #2353

Merged
merged 2 commits into from
Sep 19, 2024
Merged

i18n(ko-KR): create card-grid.mdx #2353

merged 2 commits into from
Sep 19, 2024

Conversation

jsparkdev
Copy link
Contributor

Description

  • create card-grid.mdx

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: c4496f8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added i18n Anything to do with internationalization & translation efforts 📚 docs Documentation website changes labels Sep 19, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 19, 2024 •
edited
Loading

✅ Deploy Preview for astro-starlight ready!

Name Link
🔨 Latest commit c4496f8
🔍 Latest deploy log https://app.netlify.com/sites/astro-starlight/deploys/66ebe1502147280008c5db98
😎 Deploy Preview https://deploy-preview-2353--astro-starlight.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@astrobot-houston
Copy link
Collaborator

astrobot-houston commented Sep 19, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
ko components/card-grids.mdx Localization added, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

This was referenced Sep 19, 2024
Merged
Merged
HiDeoo
HiDeoo approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@HiDeoo HiDeoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the translation 🙌

As a non-native speaker, I reviewed this PR using the Docs Translation Review Checklist and everything looks in order.

Small note: if you want to translate the preview component "Preview" label in a new PR, it's using a custom UI string and you should be able to create a new JSON file with the translation for the UI string, e.g. the French version.

image

@HiDeoo HiDeoo merged commit 631c1c3 into withastro:main Sep 19, 2024
15 checks passed
@jsparkdev jsparkdev deleted the card-grid branch September 19, 2024 10:07
@jsparkdev
Copy link
Contributor Author

@HiDeoo Thank you for this tip! I've opened #2365 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HiDeoo HiDeoo HiDeoo approved these changes

Assignees
No one assigned
Labels
📚 docs Documentation website changes i18n Anything to do with internationalization & translation efforts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsparkdev @astrobot-houston @HiDeoo